New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4452 #77
DOC-4452 #77
Conversation
33663ce
to
fcc93ac
Compare
c335762
to
5a509ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename method to fiveMinutesFromNow
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -275,6 +275,10 @@ include::{snippet}[tag=batch,indent=0] | |||
At the *local* level this operation is still transactional: no other `Database` instances, including ones managed by the replicator can make changes during the execution of the block, and other instances will not see partial changes. | |||
But Couchbase Mobile is a distributed system, and due to the way replication works, there's no guarantee that Sync Gateway or other devices will receive your changes all at once. | |||
|
|||
=== Document Expiration | |||
|
|||
include::{partialsdir}/document-expiration.adoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I've never included a partial this way. I've always used include::partial$document-expiration.adoc[]
https://docs.antora.org/antora/2.0/asciidoc/include-partial/#include-a-partial-from-the-same-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I recently found out about partial$
. Filed https://issues.couchbase.com/browse/DOC-5125 to be consistent with other components.
This reverts commit 9ca728e. Conflicts: modules/ROOT/pages/swift.adoc
cf559af
to
341a54f
Compare
https://issues.couchbase.com/browse/DOC-4452