Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jscbc 831 named scopes first #119

Merged

Conversation

osfameron
Copy link
Collaborator

No description provided.

Copy link
Contributor

@maria-robobug maria-robobug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, just minor comments added!

@@ -39,7 +39,7 @@ Note: We have used the `-y` flag to take the initialization defaults. To change

[source,json,indent=0]
----
include::../examples/getting-started/package.json[tag=start-using-package-json]
include::../examples/getting-started/package.json[tags=**]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question for my benefit, what does [tags=**] do?
I vaguely remember you mentioned Antora tags in the package.json, were they causing issues or just seemed odd?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shows everything, even if not tagged (as .json doesn't have comments so can't be tagged and remain valid)

This only worked for the KV APIs though -- Query, Search, Views, and other services exposed their JSON rows/hits in different ways.
All of this has been unified in SDK 3 under a single concept: serializers and transcoders.

By default, all KV APIs transcode to and from JSON -- you can also provide java POJOs which you couldn't in the past.
By default, all KV APIs transcode to and from JSON -- you can also provide java POJOs which you couldn't in the past.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs instead of java.

@osfameron osfameron merged commit 9240e4f into couchbase:release/3.2 Jul 20, 2021
@osfameron osfameron deleted the JSCBC-831-named-scopes-first branch July 20, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants