DOC-7628 fix analytics code sample and add scoped section #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maria-robobug
approved these changes
Jun 7, 2021
| @@ -87,9 +88,30 @@ def main(self, args): | |||
|
|
|||
| # tag::rowsasobject[] | |||
| result = cluster.analytics_query( | |||
| "select * from `travel-sample` limit 10" | |||
| "select * from airports limit 10" | |||
There was a problem hiding this comment.
Maybe we can add a comment to say what's required for this code snippet to work? Will you need an airports DATAVERSE (can't remember if it's still called that)?
There was a problem hiding this comment.
Yes! I've done that for the other SDK examples, will add...
(Though presumably the automation will add this too, at which point the dependencies will be specified in the README rather than needing to be dropped in various random files?)
There was a problem hiding this comment.
Yeah indeed! It might be useful for when we automate also to remind us what's required for the example to work. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.