Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYCBC-1082 named scopes #159

Merged
merged 8 commits into from Jul 20, 2021

Conversation

osfameron
Copy link
Collaborator

Also subsumed Query part of https://issues.couchbase.com/browse/DOC-8159

Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment/question on kv-operations.adoc page. Beyond that, LGTM!

@osfameron osfameron merged commit 48221af into couchbase:release/3.2 Jul 20, 2021
@osfameron osfameron deleted the PYCBC-1082-named-scopes branch July 20, 2021 17:54
@@ -67,11 +67,11 @@ And take a look at the xref:howtos:working-with-collections.adoc[developer previ
.Practical Howto Docs

[.content]
Connect to our services -- xref:howtos:kv-operations.adoc[data (KV)];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you turn off this sort of auto-blank-space-attack when doing large PRs,
it makes them very noisy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a default setting in VSCode, can probably turn it off...
I've resorted to "Hide whitespace changes" in github view on occasion btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants