New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/7.1 Eventing Listening to Multiple Collections #2851
Merged
jon-strabala
merged 18 commits into
couchbase:release/7.1
from
jon-strabala:release/7.1
Jul 29, 2022
Merged
Release/7.1 Eventing Listening to Multiple Collections #2851
jon-strabala
merged 18 commits into
couchbase:release/7.1
from
jon-strabala:release/7.1
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add navigation
RayOffiah
requested changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of general comments:
- Filenames must always be lower case, with a hypen to separate words. We have occasionally run into problems with mixed case file names when compiling between Windows and Unix-like operating systems: https://docs.couchbase.com/home/contribute/pages.html#file-format-and-name
- Always handy to put common blocks of text in attribute or an included file.
- For stuff like variables or wildcards, use backticks rather than quotes.
- One sentence per line.
modules/eventing/pages/eventing-advanced-keyspace-accessors.adoc
Outdated
Show resolved
Hide resolved
modules/eventing/pages/eventing-advanced-keyspace-accessors.adoc
Outdated
Show resolved
Hide resolved
modules/eventing/pages/eventing-advanced-keyspace-accessors.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Ray <77050471+RayOffiah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need information about Listening to Multiple Collections in Eventing and a concrete example as per 7.1.1