Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-7344: Updates to Contributor's Guide #275

Closed
wants to merge 651 commits into from

Conversation

simon-dew
Copy link
Contributor

Cherry-picking #270 into staging branch

Doc issue: DOC-7344

jamesnocentini and others added 30 commits April 30, 2019 17:42
- always use double handlebars to output URLs
- fix title, canonical URL, and indentation in tutorials layout
- look for SHOW_FEEDBACK_BUTTON env var instead of FEEDBACK_BUTTON
- only load mark.js script for tutorials layout
- change View Latest button to point to current URL if SUPPORTS_CURRENT_URL env var is true
- change canonical link to point to current URL if SUPPORTS_CURRENT_URL env var is true
- always consult UI model to get start URL or version of component
- resolve all URLs and versions of components from UI model
- change View Latest button to point to current URL if SUPPORTS_CURRENT_URL env var is true
- change canonical link to point to current URL if SUPPORTS_CURRENT_URL env var is true
- always consult UI model to get start URL or version of component
- resolve all URLs and versions of components from UI model
- always use double handlebars to output URLs
- fix title, canonical URL, and indentation in tutorials layout
- look for SHOW_FEEDBACK_BUTTON env var instead of FEEDBACK_BUTTON
- only load mark.js script for tutorials layout
…pt [skip ci]

* upgrade docker base image to algolia/docsearch-scraper:v1.3
* set UPDATE_NB_HITS=false and remove workaround
* remove node-based activate script (leaving only the python one)
Copy link
Collaborator

@RichardSmedley RichardSmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojavelinux
Copy link
Contributor

Please rebase and this will once again deploy successfully.

@mojavelinux
Copy link
Contributor

This PR seems to contain more than just update the contributors guide. Can you keep the changes to the build and playbook configuration separate?

@mojavelinux
Copy link
Contributor

GitHub forced this issue to be closed because of a conflict with the new staging branch. Sorry about that. Can you submit a new PR?

@mojavelinux
Copy link
Contributor

Nevermind. I have synced the changes. Just let me know if anything looks missing.

In the future, please don't submit changes to the contributing guide to the staging branch. The staging branch is only meant for sharing new content that is not yet ready for production, but should be on an official domain (docs-staging.couchbase.com). In almost all cases, you should be submitting a PR to the master branch. We can then backport changes periodically to staging. (Though it would be better the contribute module were not in the playbook repository at all so that it could be shared by different environments, but that's a separate task).

@simon-dew simon-dew deleted the DOC-7344-staging branch November 22, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet