Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-4216 #24

Merged
merged 4 commits into from Dec 11, 2018
Merged

DOC-4216 #24

merged 4 commits into from Dec 11, 2018

Conversation

jamesnocentini
Copy link
Contributor

@bbrks bbrks self-assigned this Nov 21, 2018
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tweaked some of the wording, and changed the units Mb -> MB.

I think GitHub lets you accept these suggestions in bulk through the web UI now if you agree.

modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/data-routing.adoc Outdated Show resolved Hide resolved
Co-Authored-By: jamiltz <james.nocentini@gmail.com>
@jamesnocentini
Copy link
Contributor Author

@bbrks great thanks.
And wow the bulk accept suggestion feature is so good.

@jamesnocentini
Copy link
Contributor Author

@adamcfraser, awaiting your PR approval (for correctness).

@bbrks can you OK the PR following the changes?

@bbrks
Copy link
Member

bbrks commented Dec 7, 2018

Hey @jamiltz ,

I've discussed this change with @adamcfraser and I think we're going to change tack a little bit.

We'll be improving the stats monitoring and error/warnings related to this inside Sync Gateway for the next version, and instead provide a section in the docs with a "What to do when your channel count nears/exceeds usable space" so the user can solve their problem.

The new section should describe that in order to alleviate oversized channel metadata, they should lower one or more of the following:

  1. number of channels per document
  2. channel name lengths
  3. revs_limit

@jamesnocentini
Copy link
Contributor Author

Thanks @bbrks , updated the PR. Let me know if it needs further modifications.

Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for those changes @jamiltz

@jamesnocentini jamesnocentini merged commit 07ff83c into release/2.1 Dec 11, 2018
@jamesnocentini jamesnocentini deleted the doc-4216 branch December 11, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants