Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle binary and int values in ValueSlot::copyValue #172

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Handle binary and int values in ValueSlot::copyValue #172

merged 1 commit into from
Jul 19, 2023

Conversation

blaugold
Copy link
Contributor

@blaugold blaugold commented Nov 6, 2022

With this change all types of values that might not be inlinable into ValueSlot are handled in ValueSlot::copyValue.

NB: This was discovered through fuzzing (#166).

@blaugold blaugold mentioned this pull request Nov 6, 2022
Draft
snej
snej approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@snej snej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I must've forgotten binary entirely, and mis-assumed ints would always be small enough to fit inline.

@snej snej merged commit 5c5c15c into couchbase:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snej snej snej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blaugold @snej