Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Xcode config, Test_CE. It is a duplicate of Debug. We need … #183

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

jianminzhao
Copy link
Contributor

…it for 'LiteCore C++ Tests'/Test_CE. C.F. CBL 4687

…it for 'LiteCore C++ Tests'/Test_CE. C.F. CBL 4687
Copy link
Contributor

@callumbirks callumbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not opposed to this at all, but I just wonder what is the motivation for it?

Copy link
Member

@borrrden borrrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about CMake?

@jianminzhao
Copy link
Contributor Author

For CMake, it is clear. I can a define to the CMake (pseudo) library, LiteCoreUnitTesting, which is the exactly the same as LiteCoreObjects except for an additional DEFINE, and CppTest executable links to LiteCoreUnitTesting rather than LiteCoreObjects. For Xcode, I have to add DEFINEs per build configuration.

@borrrden borrrden self-requested a review July 10, 2023 23:54
@jianminzhao jianminzhao merged commit ea7b06d into master Jul 10, 2023
3 checks passed
@jianminzhao jianminzhao deleted the cbl-4687 branch July 10, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants