Fixed a bug in FLEncoder_LastValueWritten, FLEncoder_Snip, FLEncoder_WriteValueAgain #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WriteValueAgain The internal enum type Encoder::PreWrittenValue had a badly-chosen "none" value of 0, which could easily occur as a valid value. This meant Encoder::lastValueWritten() would return a false negative if the last value written was the first value (at offset 0.) This in turn meant Encoder::snip() would return nullslice in this case. This in turn broke LiteCore's VectorRecord in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal enum type Encoder::PreWrittenValue had a badly-chosen "none" value of 0, which could easily occur as a valid value.
This meant Encoder::lastValueWritten() would return a false negative if the last value written was the first value (at offset 0.)
This in turn meant Encoder::snip() would return nullslice in this case.
This in turn broke LiteCore's VectorRecord.
This fix shouldn't affect anything, since these API calls are only used by LiteCore's version vector code, which is still disabled.