CBL-4824: Move fixes for 3.1.2 from next/3.1 to release/3.1
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borrrden
requested changes
Aug 16, 2023
|
Yeah I think I did this the wrong way. Going to redo |
jianminzhao
reviewed
Aug 25, 2023
Xcode/xcconfigs/FleeceTest.xcconfig
Outdated
| @@ -13,7 +13,7 @@ | |||
| // | |||
|
|
|||
| // Workaround for Catch 2 requiring C++ features not available until macOS 10.12 | |||
There was a problem hiding this comment.
Is the comment still valid?
There was a problem hiding this comment.
Probably not, no. I can remove it
borrrden
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Core release branch requires Fleece submodule points to matching release branch.
This is merged from master up to the point required for CBL-4824, which is the Xcode 14.3 fixes that allow Core to build.