Explicit convert UINT64_MAX to unsigned #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…64_MAX to unsigned with @() after we upgraded MACOSX_DEVELOPMENT_TARGET to 12 from 10.14. A test is falied because of it. Fix it by explict cast.
pasin
approved these changes
Apr 8, 2024
Tests/ObjCTests.mm
Outdated
| @@ -62,7 +62,10 @@ static void checkIt(id obj, const char* json) { | |||
| checkIt(@123456789, "123456789"); | |||
| checkIt(@123456789012, "123456789012"); | |||
| checkIt(@(INT64_MAX), "9223372036854775807"); | |||
| checkIt(@(UINT64_MAX), "18446744073709551615"); | |||
| // checkIt(@(UINT64_MAX), "18446744073709551615"); | |||
There was a problem hiding this comment.
okay. I was waving between whether to remove it.
snej
reviewed
Apr 12, 2024
| checkIt(@(UINT64_MAX), "18446744073709551615"); | ||
| // It was found that @() may not turn UINT64_MAX to unsigned. In the following, | ||
| // we apply an explicit conversion | ||
| checkIt(@([@UINT64_MAX unsignedLongLongValue]), "18446744073709551615"); |
There was a problem hiding this comment.
This is unnecessarily convoluted. You create an NSNumber, turn it back into a native number, then create another NSNumber from that.
It would be much simpler to write [NSNumber numberWithUnsignedLongLong: UINT64_MAX].
Or else @((unsigned long long)UINT64_MAX)
There was a problem hiding this comment.
Thanks for the advice. This is test code and won't be in the product. I will change when ported the the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Jenkins' build machine (MacOS), we found it failed to convert UINT64_MAX to unsigned with @() after we upgraded MACOSX_DEVELOPMENT_TARGET to 12 from 10.14.
A test is falied because of it. Fix it by explicit cast.