Update how we redact configs to not contain ineffectual assignments

Change-Id: Id51d359f1729446af4628fa626d1a50edfb8bfa9 Reviewed-on: http://review.couchbase.org/c/gocbcore/+/147623 Reviewed-by: Brett Lawson <brett19@gmail.com> Tested-by: Charles Dixon <chvckd@gmail.com>
couchbase · Mar 8, 2021 · 7e49c85 · 7e49c85
1 parent fd90663
commit 7e49c85
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/agent_config.go b/agent_config.go
@@ -83,8 +83,7 @@ type AgentConfig struct {
 }
 
 func (config *AgentConfig) redacted() interface{} {
-	newConfig := AgentConfig{}
-	newConfig = *config
+	newConfig := *config
 	if isLogRedactionLevelFull() {
 		// The slices here are still pointing at config's underlying arrays
 		// so we need to make them not do that.

diff --git a/clusteragent_config.go b/clusteragent_config.go
@@ -26,8 +26,7 @@ type clusterAgentConfig struct {
 }
 
 func (config *clusterAgentConfig) redacted() interface{} {
-	newConfig := clusterAgentConfig{}
-	newConfig = *config
+	newConfig := *config
 	if isLogRedactionLevelFull() {
 		// The slices here are still pointing at config's underlying arrays
 		// so we need to make them not do that.

diff --git a/dcpagent_config.go b/dcpagent_config.go
@@ -60,8 +60,7 @@ type DCPAgentConfig struct {
 }
 
 func (config *DCPAgentConfig) redacted() interface{} {
-	newConfig := DCPAgentConfig{}
-	newConfig = *config
+	newConfig := *config
 	if isLogRedactionLevelFull() {
 		// The slices here are still pointing at config's underlying arrays
 		// so we need to make them not do that.