Reorder the sequence for GetRbacDatabase

This removes the need of a reconnect

Change-Id: I8af9cc025f93034170a0bb24a24e7f65ba2d9cb0
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/160286
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>

tests/testapp/testapp_misc.cc

@@ -107,17 +107,18 @@ TEST_P(MiscTest, UpdateUserPermissionsInvalidPayload) {
  * add tests to verify the content
  */
 TEST_P(MiscTest, GetRbacDatabase) {
-    auto& conn = getAdminConnection();
+    // Verify that we need privileges to do this
+    auto& conn = getConnection();
     auto response = conn.execute(BinprotGenericCommand{
             cb::mcbp::ClientOpcode::IoctlGet, "rbac.db.dump?domain=external"});
-    ASSERT_TRUE(response.isSuccess());
-    ASSERT_FALSE(response.getDataString().empty());
+    ASSERT_FALSE(response.isSuccess());
+    ASSERT_EQ(cb::mcbp::Status::Eaccess, response.getStatus());
 
-    prepare(conn);
+    conn.authenticate("@admin", mcd_env->getPassword("@admin"));
     response = conn.execute(BinprotGenericCommand{
             cb::mcbp::ClientOpcode::IoctlGet, "rbac.db.dump?domain=external"});
-    ASSERT_FALSE(response.isSuccess());
-    ASSERT_EQ(cb::mcbp::Status::Eaccess, response.getStatus());
+    ASSERT_TRUE(response.isSuccess());
+    ASSERT_FALSE(response.getDataString().empty());
 }
 
 TEST_P(MiscTest, Config_Validate_Empty) {