Skip to content

Commit

Permalink
MB-48569: Remove spurious warning when readLocalDoc fails
Browse files Browse the repository at this point in the history
Failing to read a local doc isn't necessarily something to warn about
- the docuemnt may not simply exist yet (for example in the case of
_local/collections/dropped).

Remove the warning here, the caller already gets passed back the full
status and can log or not as applicable.

Change-Id: Id28dd609d5f5ab5cf39162576e491984184fc490
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/165263
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@couchbase.com>
  • Loading branch information
daverigby committed Nov 9, 2021
1 parent 5438820 commit 4b4ff9a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions engines/ep/src/kvstore/magma-kvstore/magma-kvstore.cc
Expand Up @@ -1963,10 +1963,6 @@ std::pair<Status, std::string> MagmaKVStore::processReadLocalDocResult(
status.ErrorCode(),
"MagmaKVStore::readLocalDoc " + vbid.to_string() +
" key:" + keySlice.ToString() + " " + status.String());
logger->warn("MagmaKVStore::readLocalDoc {} key:{} returned status: {}",
vbid,
keySlice.ToString(),
status.String());
} else {
if (!found) {
retStatus = magma::Status(
Expand Down

0 comments on commit 4b4ff9a

Please sign in to comment.