MB-47462: Add virtual destructor for CheckpointManager

Many tests substitute a MockCheckpointManager (inherits from CheckpointManager). To ensure the MockCM is handled correctly when destroyed through a std::unique_ptr<CheckpointManager>, the base type must have a virtual destructor. Change-Id: I39cf64eb97b016452fd2c9d9865d4904efb6507d Reviewed-on: http://review.couchbase.org/c/kv_engine/+/162090 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com>
couchbase · Sep 23, 2021 · fddcfad · fddcfad
1 parent 14fbcdd
commit fddcfad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/engines/ep/src/checkpoint_manager.cc b/engines/ep/src/checkpoint_manager.cc
@@ -67,6 +67,8 @@ CheckpointManager::CheckpointManager(EPStats& st,
     }
 }
 
+CheckpointManager::~CheckpointManager() = default;
+
 uint64_t CheckpointManager::getOpenCheckpointId(
         const std::lock_guard<std::mutex>& lh) {
     return getOpenCheckpoint_UNLOCKED(lh).getId();

diff --git a/engines/ep/src/checkpoint_manager.h b/engines/ep/src/checkpoint_manager.h
@@ -147,6 +147,8 @@ class CheckpointManager {
                       uint64_t maxVisibleSeqno,
                       FlusherCallback cb);
 
+    virtual ~CheckpointManager();
+
     uint64_t getOpenCheckpointId();
 
     uint64_t getLastClosedCheckpointId();