bc_file bugfixes

- Always update last_mtime after successful update
- Don't check vbucket changes. This is done by confmon and the core

Change-Id: I7d5b62149ca372ff8881f7673697adb9458f11b6
Reviewed-on: http://review.couchbase.org/34988
Reviewed-by: Subhashni Balakrishnan <b.subhashni@gmail.com>
Tested-by: Mark Nunberg <mnunberg@haskalah.org>

src/bucketconfig/bc_file.c

@@ -114,19 +114,6 @@ static int load_cache(file_provider *provider)
         goto GT_DONE;
     }
 
-    if (provider->config) {
-        VBUCKET_CHANGE_STATUS chstatus;
-        VBUCKET_CONFIG_DIFF *diff = vbucket_compare(provider->config->vbc, config);
-        if (diff == NULL) {
-            goto GT_DONE;
-        }
-        chstatus = vbucket_what_changed(diff);
-        vbucket_free_diff(diff);
-        if (chstatus == VBUCKET_NO_CHANGES) {
-            goto GT_DONE;
-        }
-    }
-
     if (provider->config) {
         lcb_clconfig_decref(provider->config);
     }
@@ -136,6 +123,7 @@ static int load_cache(file_provider *provider)
                                            LCB_CLCONFIG_FILE);
     provider->config->cmpclock = gethrtime();
     provider->config->origin = provider->base.type;
+    provider->last_mtime = st.st_mtime;
     status = 0;
     config = NULL;