Skip to content

Commit

Permalink
Move ns_minify into separate gomodules directory
Browse files Browse the repository at this point in the history
Turns out we can't mix go modules and non-modules Go code. Separate
out any modules-built code into new deps/gomodules directory.

Change-Id: I9a4e6291a378dce3e4c375c4233ef2074f99a167
Reviewed-on: https://review.couchbase.org/c/ns_server/+/165622
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Pavel Blagodov <stochmail@gmail.com>
Tested-by: Chris Hillery <ceej@couchbase.com>
  • Loading branch information
ceejatec committed Nov 12, 2021
1 parent 620b300 commit 67e34db
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 17 deletions.
1 change: 1 addition & 0 deletions deps/CMakeLists.txt
Expand Up @@ -9,4 +9,5 @@ ADD_SUBDIRECTORY (meck)
ADD_SUBDIRECTORY (ns_babysitter)
ADD_SUBDIRECTORY (ns_couchdb)
ADD_SUBDIRECTORY (gocode)
ADD_SUBDIRECTORY (gomodules)
ADD_SUBDIRECTORY (chronicle)
4 changes: 0 additions & 4 deletions deps/gocode/CMakeLists.txt
Expand Up @@ -18,10 +18,6 @@ GoInstall (TARGET ns_godu PACKAGE godu
GOVERSION 1.8.5
INSTALL_PATH bin/priv)

GoModBuild (TARGET ns_minify PACKAGE github.com/couchbase/ns_server/deps/gocode/src/minify
GOVERSION 1.13
OUTPUT minify)

GoInstall (TARGET ns_gosecrets PACKAGE gosecrets
GOPATH "${CMAKE_CURRENT_SOURCE_DIR}" "${GODEPSDIR}"
GOVERSION 1.8.5
Expand Down
2 changes: 2 additions & 0 deletions deps/gomodules/CMakeLists.txt
@@ -0,0 +1,2 @@
ADD_SUBDIRECTORY(minify)

4 changes: 4 additions & 0 deletions deps/gomodules/minify/CMakeLists.txt
@@ -0,0 +1,4 @@
GoModBuild (TARGET ns_minify PACKAGE ns_server_minify
GOVERSION 1.13
OUTPUT minify)

2 changes: 1 addition & 1 deletion go.mod → deps/gomodules/minify/go.mod
@@ -1,4 +1,4 @@
module github.com/couchbase/ns_server
module ns_server_minify

go 1.17

Expand Down
4 changes: 4 additions & 0 deletions deps/gomodules/minify/go.sum
@@ -0,0 +1,4 @@
github.com/evanw/esbuild v0.12.27 h1:pWtTIKGO4Af2P2u6Jps5vmJy1wpUqdx4QmI1Y/fvxY8=
github.com/evanw/esbuild v0.12.27/go.mod h1:GG+zjdi59yh3ehDn4ZWfPcATxjPDUH53iU4ZJbp7dkY=
golang.org/x/sys v0.0.0-20210908233432-aa78b53d3365 h1:6wSTsvPddg9gc/mVEEyk9oOAoxn+bT4Z9q1zx+4RwA4=
golang.org/x/sys v0.0.0-20210908233432-aa78b53d3365/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
File renamed without changes.
12 changes: 0 additions & 12 deletions go.sum

This file was deleted.

0 comments on commit 67e34db

Please sign in to comment.