Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook event not fired when using bucket shadowing #2500

Closed
ajres opened this issue Apr 25, 2017 · 5 comments · Fixed by #2524
Closed

Webhook event not fired when using bucket shadowing #2500

ajres opened this issue Apr 25, 2017 · 5 comments · Fixed by #2524
Assignees
@ajres
Labels
bug ffc P1: high
Milestone
1.5.0

Comments

@ajres
Copy link

ajres commented Apr 25, 2017 •
edited by djpongh

Commit ebb92f9, from PR #2014 introduced a regression that results in no WebHook events being fired for document updates triggerd by processing changes from a shadow bucket feed.
@ajres
Copy link
Author

ajres commented Apr 25, 2017

Regression is in db/crud.go in function UpdateDoc

@ajres
Copy link
Author

ajres commented Apr 25, 2017

Need to add a failing unit test to catch this regression, then fix.

@tleyden
Copy link
Contributor

tleyden commented Apr 26, 2017

Looks like there is also a functional test that tests webhooks.

@sethrosetter any idea if this test is currently passing on the latest master branch?

@adamcfraser
Copy link
Collaborator

@tleyden I don't think those functional tests include bucket shadowing.

@tleyden
Copy link
Contributor

tleyden commented Apr 26, 2017

Yeah you're right, thanks for the clarification

@djpongh djpongh added this to the 1.4.2 milestone Apr 28, 2017
@djpongh djpongh added the ready label Apr 28, 2017
@ajres ajres mentioned this issue May 4, 2017
Merged
@hideki hideki added the review label May 4, 2017
@jamesnocentini jamesnocentini changed the title Shadower/webhook regression introduced by commit ebb92f9 Webhook event not fired when using bucket shadowing Jun 15, 2017
@tleyden tleyden mentioned this issue Jun 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajres ajres

Labels
bug ffc P1: high
Projects
None yet
Milestone
1.5.0
6 participants
@hideki @tleyden @jamesnocentini @ajres @adamcfraser @djpongh