Better error if a pushed document fails to be saved

If remote _bulk_docs indicates an error saving a document, (a) Map "unauthorized" message to 401 status (instead of default 502) (b) Put the document's URL in the NSError object's userInfo.
couchbaselabs · Nov 14, 2012 · dee1afe · dee1afe
1 parent 399d477
commit dee1afe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Source/TDPusher.m b/Source/TDPusher.m
@@ -254,7 +254,12 @@ - (void) uploadBulkDocs: (NSArray*)docsToSend
                           if (item[@"error"]) {
                               // One of the docs failed to save:
                               Warn(@"%@: _bulk_docs got an error: %@", self, item);
-                              error = TDStatusToNSError(kTDStatusUpstreamError, nil);
+                              TDStatus status = kTDStatusUpstreamError;
+                              if ($equal(item[@"error"], @"unauthorized"))
+                                  status = kTDStatusUnauthorized;
+                              NSString* docID = item[@"id"];
+                              NSURL* url = docID ? [_remote URLByAppendingPathComponent: docID] : nil;
+                              error = TDStatusToNSError(status, url);
                           }
                       }
                   }

diff --git a/Source/TDStatus.h b/Source/TDStatus.h
@@ -16,6 +16,7 @@ typedef enum {
     kTDStatusNotModified    = 304,
 
     kTDStatusBadRequest     = 400,
+    kTDStatusUnauthorized   = 401,
     kTDStatusForbidden      = 403,
     kTDStatusNotFound       = 404,
     kTDStatusNotAcceptable  = 406,