Fix various Linux/GCC build issues by being more standards conformant. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly including the right headers in the right places, plus a few fixes for type declarations.
This was referenced May 11, 2015
Closed
| .body = (void*)body.buf, | ||
| .bodylen = body.size, | ||
| }; | ||
| fdb_doc doc; |
There was a problem hiding this comment.
For safety this line should be fdb_doc doc = { }, to make sure all fields are initialized to zero. (The assignments below should fill in all the fields, but just to make sure, and in case any fields ever got added to the struct in the future.)
|
Thanks! Looks great except for the two issues with struct initialization. |
Those are valid in C99, but in no C++ spec to date. Use regular define/assign statements instead.
|
Good point. I had to check the C++ behaviour, but it seems this syntax will initialize the member variables with zeroes in both C and C++11. Updated the pull request, thanks for the review. |
snej
added a commit
that referenced
this pull request
May 13, 2015
Fix various Linux/GCC build issues by being more standards conformant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly including the right headers in the right places,
plus a few fixes for type declarations.
(Context: I'm trying to create a CMake build for CBForest. These are the changes I've got so far that improve the code without requiring any build changes.)