CXXCBC-365: handle >16 specs in lookup_in_any_replica (#441)

couchbaselabs · Aug 17, 2023 · c6be14e · c6be14e
1 parent b6148c1
commit c6be14e
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 0 deletions.
diff --git a/core/impl/lookup_in_any_replica.cxx b/core/impl/lookup_in_any_replica.cxx
@@ -63,6 +63,9 @@ initiate_lookup_in_any_replica_operation(std::shared_ptr<cluster> core,
           if (!config.supports_subdoc_read_replica()) {
               ec = errc::common::feature_not_available;
           }
+          if (r->specs().size() > 16) {
+              ec = errc::common::invalid_argument;
+          }
           if (ec) {
               std::optional<std::string> first_error_path{};
               std::optional<std::size_t> first_error_index{};

diff --git a/core/operations/document_lookup_in_any_replica.hxx b/core/operations/document_lookup_in_any_replica.hxx
@@ -69,6 +69,9 @@ struct lookup_in_any_replica_request {
               if (!config.supports_subdoc_read_replica()) {
                   ec = errc::common::feature_not_available;
               }
+              if (specs.size() > 16) {
+                  ec = errc::common::invalid_argument;
+              }
 
               if (ec) {
                   std::optional<std::string> first_error_path{};

diff --git a/test/test_integration_subdoc.cxx b/test/test_integration_subdoc.cxx
@@ -1487,6 +1487,21 @@ TEST_CASE("integration: subdoc any replica reads", "[integration]")
                                                couchbase::errc::key_value::path_mismatch);
     }
 
+    SECTION("too many specs")
+    {
+        couchbase::core::operations::lookup_in_any_replica_request req{ id };
+        auto specs = couchbase::lookup_in_specs{};
+
+        for (int i = 0; i < 17; i++) {
+            specs.push_back(couchbase::lookup_in_specs::get("dictkey"));
+        }
+        req.specs = specs.specs();
+
+        auto resp = test::utils::execute(integration.cluster, req);
+        REQUIRE(resp.ctx.ec() == couchbase::errc::common::invalid_argument);
+        REQUIRE(resp.fields.empty());
+    }
+
     SECTION("public API")
     {
         auto collection = couchbase::cluster(integration.cluster).bucket(integration.ctx.bucket).scope("_default").collection("_default");
@@ -1513,5 +1528,17 @@ TEST_CASE("integration: subdoc any replica reads", "[integration]")
             REQUIRE(ctx.ec() == couchbase::errc::key_value::document_irretrievable);
             REQUIRE(result.cas().empty());
         }
+
+        SECTION("too many specs")
+        {
+            auto specs = couchbase::lookup_in_specs{};
+
+            for (int i = 0; i < 17; i++) {
+                specs.push_back(couchbase::lookup_in_specs::get("dictkey"));
+            }
+            auto [ctx, result] = collection.lookup_in_any_replica(key, specs).get();
+            REQUIRE(ctx.ec() == couchbase::errc::common::invalid_argument);
+            REQUIRE(result.cas().empty());
+        }
     }
 }