CXXCBC-310 LostTxnCleanup wasn't stopping right away #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When shutting down, for instance, the lost attempt loop would not stop sometimes, leading to issues with tests sometimes. Now, I'm only accessing the running_ bool under the lock, so it is safe to use it in the wait calls as well. Seems to have been an issue, simple fix. Also - I was creating a client record doc if it was missing, when deleting. Seems unnecessary.
avsej
reviewed
Mar 24, 2023
avsej
reviewed
Mar 24, 2023
avsej
reviewed
Mar 24, 2023
Also don't wait for UDP response until deadline, leave some time for TCP attempt.
avsej
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutting down, for instance, the lost attempt loop would not stop sometimes, leading to issues with tests sometimes. Now, I'm only accessing the running_ bool under the lock, so it is safe to use it in the wait calls as well. Seems to have been an issue, simple fix.
Also - I was creating a client record doc if it was missing, when deleting, which does nothing.