Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXXCBC-327: bundle Mozilla certificates with the library #405

Merged
merged 1 commit into from May 12, 2023

Conversation

avsej
Copy link
Member

@avsej avsej commented May 9, 2023

No description provided.

@avsej avsej requested review from brett19, thejcfactor and a team May 9, 2023 19:00
@avsej
Copy link
Member Author

avsej commented May 10, 2023

Sample build info output:

{
  "_MSC_VER": "1934",
  "__cplusplus": "199711",
  "asio": "1.24.0",
  "build_timestamp": "2023-05-09 19:05:19",
  "cc": "MSVC 19.34.31944.0",
  "cmake_build_type": "Release",
  "cmake_version": "3.26.3",
  "compile_definitions": "_WIN32_WINNT=0x0601;FMT_LOCALE;SPDLOG_COMPILED_LIB;SPDLOG_FMT_EXTERNAL",
  "compile_features": "cxx_std_17;cxx_variadic_templates",
  "compile_flags": "",
  "compile_options": "/W4;/wd4189;/wd4242;/wd4244;/w14254;/w14263;/w14265;/w14287;/we4289;/w14296;/w14311;/w14545;/w14546;/w14547;/w14549;/w14555;/wd4619;/w14640;/w14826;/w14905;/w14906;/w14928;/permissive-;/WX",
  "cpu": "AMD64",
  "cxx": "MSVC 19.34.31944.0",
  "fmt": "8.800.1",
  "http_parser": "2.9.4",
  "link_depends": "",
  "link_flags": "",
  "link_libraries": "project_options;project_warnings;fmt::fmt;spdlog::spdlog;snappy;jsonsl;hdr_histogram_static;couchbase_backtrace;couchbase_logger;couchbase_platform;couchbase_meta;couchbase_crypto;couchbase_sasl;couchbase_tracing;couchbase_metrics;http_parser;iphlpapi;OpenSSL::SSL;OpenSSL::Crypto",
  "link_options": "",
  "mozilla_ca_bundle_date": "fb1ecd641d0a02c01bc9036d513cb658bbda62a75e246bedbc01764560a639f0",
  "mozilla_ca_bundle_embedded": true,
  "mozilla_ca_bundle_sha256": "Tue Jan 10 04:12:06 2023 GMT",
  "mozilla_ca_bundle_size": 137,
  "openssl_config_dir": "C:\\Program Files\\Common Files\\SSL",
  "openssl_crypto_interface_imported_location": "",
  "openssl_crypto_interface_include_directories": "C:/Program Files/OpenSSL/include",
  "openssl_crypto_interface_link_libraries": "",
  "openssl_default_cert_dir": "C:\\Program Files\\Common Files\\SSL/certs",
  "openssl_default_cert_dir_env": "SSL_CERT_DIR",
  "openssl_default_cert_file": "C:\\Program Files\\Common Files\\SSL/cert.pem",
  "openssl_default_cert_file_env": "SSL_CERT_FILE",
  "openssl_headers": "OpenSSL 1.1.1t  7 Feb 2023",
  "openssl_pkg_config_interface_include_directories": "",
  "openssl_pkg_config_interface_link_libraries": "",
  "openssl_runtime": "OpenSSL 1.1.1t  7 Feb 2023",
  "openssl_ssl_imported_location": "",
  "openssl_ssl_interface_include_directories": "C:/Program Files/OpenSSL/include;C:/Program Files/OpenSSL/include",
  "openssl_ssl_interface_link_libraries": "OpenSSL::Crypto",
  "platform": "Windows-10.0.20348",
  "platform_name": "Windows",
  "platform_version": "10.0.20348",
  "post_linked_openssl": "OFF",
  "revision": "d49907b4b294ef36e3724bf76594f4554092a1f7",
  "semver": "1.0.0+d49907b",
  "snappy": "1.1.10",
  "snapshot": false,
  "spdlog": "1.9.2",
  "static_openssl": false,
  "static_stdlib": false,
  "txns_forward_compat_extensions": "TI,MO,BM,QU,SD,BF3787,BF3705,BF3838,RC,UA,CO,BF3791,CM,SI,QC,IX,TS",
  "txns_forward_compat_protocol_version": "2.0",
  "version": "1.0.0",
  "version_build": 0,
  "version_major": 1,
  "version_minor": 0,
  "version_patch": 0
}

core/meta/version.cxx Outdated Show resolved Hide resolved
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I like the CMake incantation to build cert bundle 🙂

@avsej avsej merged commit 341e01b into couchbaselabs:main May 12, 2023
13 of 14 checks passed
@avsej avsej deleted the certs branch May 12, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants