CXXCBC-328: fix restarting MCBP sessions #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
force-pushed
the
CXXCBC-328-fix-restarting-sessions
branch
from
42d9207
to
211d2d2
Compare
avsej
force-pushed
the
CXXCBC-328-fix-restarting-sessions
branch
3 times, most recently
from
19583d8
to
bd4061b
Compare
avsej
force-pushed
the
CXXCBC-328-fix-restarting-sessions
branch
6 times, most recently
from
e0a6a37
to
c9cb230
Compare
Instead of letting session restarting itself, only allow it to removed itself from the bucket. And in the end, just notify the bucket to check configuration and establish connections to the endpoints that don't have it yet.
* calculate diff of node lists taking into account active network (external/internal) * do not use indexes to decide whether the session should be preserved or closed. Instead just iterate and match existing connections using their bootstrap addresses. * tolerate auth errors during bootstrap, if the bootstrap list is not exhausted. Ejected nodes might still be available, but fail to authenticate, we should just try next in the list. * always swap bytes for opaque for log readability
avsej
force-pushed
the
CXXCBC-328-fix-restarting-sessions
branch
from
c9cb230
to
a7d8c0f
Compare
doing that will allow to restart the session, and it will not stuck in stopped state leading to timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of letting session restarting itself, only allow it to removed itself from the bucket. And in the end, just notify the bucket to check configuration and establish connections to the endpoints that don't have it yet.