New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXXCBC-242: SDK Support for Native KV Range Scans #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemetrisChr
commented
Jun 26, 2023
DemetrisChr
commented
Jun 26, 2023
avsej
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the implementation to follow the newest RFC changes
Notable changes
prefix_scan
as top-level scan typerange_scan_cancelled
error code, returningrequest_canceled
insteadconcurrency
option to orchestrator to set the maximum allowed level of concurrencyrange_scan_orchestrator
takes the vbucket map instead of the number of vbucketsrange_scan_timeout
tokey_value_scan_timeout
in timeout defaultsbatch_time_limit
from options, 90% of the timeout is used insteadnext
methods of the scan result can return an error code in the case of a fatal errorcancel()
method toscan_result
that can cancel all streams