Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return invalid_argument error code when concurrency is not positive in range scan #426

Merged
merged 1 commit into from Jul 5, 2023
Merged

Return invalid_argument error code when concurrency is not positive in range scan #426

merged 1 commit into from Jul 5, 2023

Conversation

DemetrisChr
Copy link
Contributor

@DemetrisChr DemetrisChr commented Jul 5, 2023 •
edited

  • errc::common::invalid_argument when concurrency is non-positive
  • Some tidying up in the tests - created a get_vbucket_map() function to make the code less repetitive

@DemetrisChr DemetrisChr requested a review from avsej July 5, 2023 08:59
@avsej
Copy link
Member

avsej commented Jul 5, 2023

Jenkins, test this please

@programmatix
Copy link
Contributor

Optional but if you get a moment, would be awesome to add a FIT test for this so that other SDKs benefit.

@DemetrisChr
Copy link
Contributor Author

DemetrisChr commented Jul 5, 2023 •
edited

Optional but if you get a moment, would be awesome to add a FIT test for this so that other SDKs benefit.

@programmatix I've added a few tests here (both for valid values of concurrency and 0) https://review.couchbase.org/c/transactions-fit-performer/+/193436

@avsej avsej merged commit 1ccb62a into couchbaselabs:main Jul 5, 2023
13 of 14 checks passed
@DemetrisChr DemetrisChr deleted the concurrency-zero-kvrs branch July 5, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@DemetrisChr @avsej @programmatix