Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXXCBC-119 Subdoc exists should return a true/false value rather than error #444

Merged
merged 1 commit into from Aug 18, 2023
Merged

CXXCBC-119 Subdoc exists should return a true/false value rather than error #444

merged 1 commit into from Aug 18, 2023

Conversation

Matt-Woz
Copy link
Contributor

Changes:

  • Subdoc exists spec doesn't return an error, per the RFC
  • Fixed bug with public API lookupInReplica not setting per-entry error code

@Matt-Woz Matt-Woz requested a review from avsej August 18, 2023 12:17
@Matt-Woz Matt-Woz merged commit f976f36 into couchbaselabs:main Aug 18, 2023
12 of 14 checks passed
@Matt-Woz Matt-Woz deleted the CXXCBC-119_subdoc_should_return_true_false_rather_than_error branch August 18, 2023 15:18
@DemetrisChr DemetrisChr mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Matt-Woz @avsej