New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXXCBC-377: Implement ExtParallelUnstaging in transactions #457
Merged
avsej
merged 6 commits into
couchbaselabs:main
from
DemetrisChr:CXXCBC-377-parallel-unstaging
Oct 24, 2023
Merged
CXXCBC-377: Implement ExtParallelUnstaging in transactions #457
avsej
merged 6 commits into
couchbaselabs:main
from
DemetrisChr:CXXCBC-377-parallel-unstaging
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmatix
reviewed
Oct 4, 2023
DemetrisChr
force-pushed
the
CXXCBC-377-parallel-unstaging
branch
2 times, most recently
from
October 13, 2023 14:04
ab6670a
to
57e05f0
Compare
DemetrisChr
changed the title
CXXCBC-377: Support ExtParallelUnstaging
CXXCBC-377: Implement ExtParallelUnstaging in transactions
Oct 13, 2023
DemetrisChr
force-pushed
the
CXXCBC-377-parallel-unstaging
branch
2 times, most recently
from
October 17, 2023 11:56
ab6670a
to
de48409
Compare
DemetrisChr
force-pushed
the
CXXCBC-377-parallel-unstaging
branch
2 times, most recently
from
October 18, 2023 22:31
dbc7cf4
to
bdbe1a3
Compare
DemetrisChr
force-pushed
the
CXXCBC-377-parallel-unstaging
branch
from
October 19, 2023 08:38
bdbe1a3
to
0ee2b9c
Compare
DemetrisChr
commented
Oct 19, 2023
… block & small fixes
avsej
force-pushed
the
CXXCBC-377-parallel-unstaging
branch
from
October 24, 2023 20:48
0ee2b9c
to
aee1504
Compare
avsej
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement the ExtParallelUnstaging extension. Unstaging in parallel will be a major performance improvement, especially for larger transactions.
Changes
commit_doc
,remove_doc
,rollback_insert
androllback_remove_or_replace
to achieve this, making use of the KV operations' handlersunstaging_state
that is used to limit the number of mutations being unstaged in parallel and prevents any further unstaging if an error has occurredasync_exp_delay
andasync_constant_delay
which use an asio timer to perform an asynchronous wait and then invoke a callback (delay calculated in the same way asexp_delay
andconstant_delay
) - used for retries during unstagingResults
ExtParallelUnstagingTest
in FIT passes