CXXCBC-387: Optimising tags for noop_tracer #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al/remote sessions Profiling indicates that non-trivial time is spent assigning tags to spans, which is wasted effort if noop_tracer is being used. Borrowing an optimisation from the JVM SDKs, where we skip this assignment in this case. This optimisation, together with another small one that will be submitted separately, produced around a 15% performance improvement.
avsej
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling indicates that non-trivial time is spent assigning tags to spans, which is wasted effort if noop_tracer is being used.
Borrowing an optimisation from the JVM SDKs, where we skip this assignment in this case.
This optimisation, together with another small one that will be submitted separately, produced around a 15% performance improvement.
Downside: this does have to touch the public request_span API.