Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXXCBC-404: KV_LOCKED status should be exposed as cas_mismatch for unlock #479

Merged
merged 2 commits into from Nov 16, 2023
Merged

CXXCBC-404: KV_LOCKED status should be exposed as cas_mismatch for unlock #479

merged 2 commits into from Nov 16, 2023

Conversation

DemetrisChr
Copy link
Contributor

KV_LOCKED should be exposed as cas_mismatch only for the unlock operation. This makes it consistent with the behaviour of other SDKs and the expectation of the relevant FIT test.

From the retry handling RFC:

Locked 0x09 (Reason: KV_LOCKED)
Note: do NOT retry on KV_LOCKED for the "Unlock" command (the retry handler should never see it in the first place! (Reason is that this needs to be surfaced as a cas mismatch exception to the user and not being retried

@avsej avsej merged commit bc560e2 into couchbaselabs:main Nov 16, 2023
13 of 14 checks passed
@DemetrisChr DemetrisChr deleted the cas-mismatch branch November 16, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

@thejcfactor thejcfactor Awaiting requested review from thejcfactor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DemetrisChr @avsej