Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXXCBC-391: Fix transactions API bugs #482

Merged

Conversation

DemetrisChr
Copy link
Contributor

@DemetrisChr DemetrisChr commented Nov 22, 2023

Motivation

ExtSDKIntegration required the removal of kv_timeout and the renaming for expiration_time to timeout

Changes

  • In transactions_config, transactions_options and the command line arguments of tools:
    • Remove kv_timeout
    • Rename expiration_time to timeout
  • Set the value "kvTimeoutMs" in the transactions query requests to the key_value_durable_timeout instead of key_value_timeout

avsej
avsej previously approved these changes Nov 27, 2023
Matt-Woz
Matt-Woz previously approved these changes Nov 28, 2023
@DemetrisChr DemetrisChr merged commit 75be673 into couchbaselabs:main Nov 29, 2023
11 of 14 checks passed
@DemetrisChr DemetrisChr deleted the CXXCBC-391-transactions-api-bugs branch November 29, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants