Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXXCBC-409: Add handling for 'index does not exist' query error #492

Merged

Conversation

DemetrisChr
Copy link
Contributor

Changes

  • Handle "Index does not exist" query error
  • Add handling for the 5000 error code in document_query (copied the one from the query management operations)
  • Handle the possibility of "status" not being included in the query response - an example where this happens is with the query drop index notfound on default;

Results

All query FIT tests pass

@DemetrisChr
Copy link
Contributor Author

TODO: I should also make sure that we match on exist and not just exists as described in the RFC & review the checks on the Python side to ensure that they are all handled within the C++ SDK instead.

Note: the uppercase index for 5000 is not a mistake (also only match on exist not exists because there is a typo somewhere in query engine which might either print exist or exists depending on the codepath)
. Code 5000 AND message contains Index .+ already exist
. Code 4300 AND message contains index .+ already exist

@DemetrisChr DemetrisChr force-pushed the CXXCBC-409-index-does-not-exist branch from e3825d2 to 3ae9b5e Compare December 15, 2023 15:33
@avsej avsej force-pushed the CXXCBC-409-index-does-not-exist branch from 3ae9b5e to faddc7e Compare December 19, 2023 00:24
@avsej avsej merged commit 6376501 into couchbaselabs:main Dec 19, 2023
13 of 14 checks passed
@DemetrisChr DemetrisChr deleted the CXXCBC-409-index-does-not-exist branch December 19, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants