CXXCBC-336: Do not fallback to 8.8.8.8, if we cannot obtain system DNS server #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcfactor
reviewed
Mar 5, 2024
avsej
force-pushed
the
CXXCBC-336-do-not-fallback-to-google-dns
branch
from
faa1c11
to
00c606c
Compare
…S server Avoid assuming Google DNS and rather report DNS-SRV lookup failure. The details still logged and user still can specify their DNS server in options.
avsej
force-pushed
the
CXXCBC-336-do-not-fallback-to-google-dns
branch
from
00c606c
to
50a4b27
Compare
thejcfactor
approved these changes
Mar 5, 2024
thejcfactor
pushed a commit
to thejcfactor/couchbase-cxx-client
that referenced
this pull request
Mar 6, 2024
…S server (couchbaselabs#533) Avoid assuming Google DNS and rather report DNS-SRV lookup failure. The details still logged and user still can specify their DNS server in options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid assuming Google DNS and rather report DNS-SRV lookup failure. The details still logged and user still can specify their DNS server in options.