-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC-12145] Added missing query to example 3 of WITH RECURSIVE page - Server #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @julia-cb ! Some changes required to set the query context for the examples, create the required collections, and show the results.
Co-authored-by: Simon Dew <39966290+simon-dew@users.noreply.github.com>
Co-authored-by: Simon Dew <39966290+simon-dew@users.noreply.github.com>
@simon-dew Thanks for all the feedback!! Super helpful and all great suggestions, I applied all of them :) (also totally agree on the name diversity for the employee example - I updated it with different names) I updated the preview site to reflect all the changes you requested! https://preview.docs-test.couchbase.com/fixwithrecursive/server/current/n1ql/n1ql-language-reference/with-recursive.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 a couple of notes if you want, but I think this is good to merge as-is.
@@ -226,6 +501,17 @@ WITH RECURSIVE similar_items AS ( | |||
SELECT * FROM similar_items; | |||
---- | |||
|
|||
.Results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as-is, but for this one example I think it would also be okay just to say "this query will run until the Query service runs out of memory".
WHERE r.sourceairport!="TLV" and recroute.depth<2 | ||
) | ||
SELECT * FROM recroute LIMIT 2000; | ||
---- | ||
|
||
.Results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to repeat the results here: you could just have a line saying "The results are the same as for the previous query."
Jira ticket: DOC-12145
Capella doc PR: #201
Preview doc page (preview site password here)
Changes in this PR: