Tweaking "a/an" rule and "quotations" rule #36
Conversation
ValeStyles/Couchbase/An.yml
Outdated
| @@ -14,7 +13,7 @@ exceptions: | |||
| - '[Aa] [Uu]ser' | |||
| - '[Aa] [Uu]sername' | |||
| - '[Aa] UI' | |||
| - '[Aa] <<[BbCcDdFfGgHhJjKkLlMmNnPpQqRrSsTtVvWwXxYyZz].+>>' | |||
| - '\b[Aa] [^aeiouAEIOU\s][a-zA-Z]*' | |||
There was a problem hiding this comment.
this is for non-vowels? it wouldn't be matched by the token above, so is an odd exception?
There was a problem hiding this comment.
True. I think it was just a holdout because I was running into issues with the original regex. Let me correct that...
| @@ -4,8 +4,7 @@ link: https://docs.couchbase.com/styleguide/articles.html | |||
| level: error | |||
|
|
|||
| tokens: | |||
| - '[Aa] \b[aAeEiIoOuU].+\b' | |||
| - '[Aa] \b[Hh][Tt][Mm][Ll]\b' | |||
There was a problem hiding this comment.
is removing the "A HTML" rule intentional?
There was a problem hiding this comment.
Ah shit that was a mistake. One sec...
| @@ -4,8 +4,7 @@ link: https://docs.couchbase.com/styleguide/articles.html | |||
| level: error | |||
|
|
|||
| tokens: | |||
| - '[Aa] \b[aAeEiIoOuU].+\b' | |||
| - '[Aa] \b[Hh][Tt][Mm][Ll]\b' | |||
| - '\b[Aa]\s+[AEIOUaeiou]\w*\b' | |||
There was a problem hiding this comment.
This looks good. Word boundary, "a", any number of spaces, a word beginning with a vowel. 👍
ValeStyles/Couchbase/Quotations.yml
Outdated
| - '\x60"([^"]*)"\x60' |
There was a problem hiding this comment.
This will now only match:
backtick + quote + any number of non-quotes, + quote + backtick?
Is that what's intended? Didn't you want .* before and after to allow tokens before/after the quoted sections?
There was a problem hiding this comment.
Hmm, good point. Let's add that back in, just in case.
| - '[Rr]efer to\s+(xref:[^\s]+|https:\/\/[^\s]+|http:\/\/[^\s]+|<<[^>]+>>)' |
There was a problem hiding this comment.
I snuck this one in, too, because the original wasn't working.
Scope needs to be raw or it'll ignore the http/https links.
No description provided.