Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findOptions limit = 0 doesn't work #465

Closed
AV25242 opened this issue May 10, 2021 · 2 comments · Fixed by #482
Closed

findOptions limit = 0 doesn't work #465

AV25242 opened this issue May 10, 2021 · 2 comments · Fixed by #482
Assignees
@gsi-alejandro @ariamF11
Labels
Complete Done
Milestone
Ottoman V2 - GA

Comments

@AV25242
Copy link
Contributor

AV25242 commented May 10, 2021

In findOptions when you pass a limit of 0 it returns back all records. Whereas

Discrepancy on result based on limit option - I think its a bug. look at the file https://github.com/couchbaselabs/node-ottoman/blob/master/src/handler/find/find.ts line 55 says if(limit) and if limit is passed as 0 I think its evaluated as limit = false. Do you think so ?

This ticket is to investigate first and implement next.
@AV25242 AV25242 added the Investigation Determine next steps label May 10, 2021
@AV25242 AV25242 mentioned this issue May 10, 2021
Closed
@AV25242 AV25242 added this to the Ottoman V2 - Beta milestone May 10, 2021
@AV25242 AV25242 added enhancement and removed Investigation Determine next steps labels May 11, 2021
@AV25242
Copy link
Contributor Author

AV25242 commented May 11, 2021

Any option with a value of limit and skip should basically respect the value of 0

@AV25242
Copy link
Contributor Author

AV25242 commented May 11, 2021

Will be fixed with next release

@ariamF11 ariamF11 self-assigned this May 14, 2021
@ariamF11 ariamF11 linked a pull request May 14, 2021 that will close this issue
feat(i-465): findOptions limit = 0 doesn't work #482
Merged
@AV25242 AV25242 changed the title Investigate : findOptions limit = 0 doesn't work findOptions limit = 0 doesn't work May 17, 2021
@AV25242 AV25242 added Complete Done and removed enhancement labels May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsi-alejandro gsi-alejandro

@ariamF11 ariamF11

Labels
Complete Done
Projects
None yet
Milestone
Ottoman V2 - GA
Development

Successfully merging a pull request may close this issue.

feat(i-465): findOptions limit = 0 doesn't work couchbaselabs/node-ottoman
3 participants
@AV25242 @gsi-alejandro @ariamF11