feat: adding full text search support #746
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 93.36% 93.20% -0.17%
==========================================
Files 96 96
Lines 2667 2677 +10
Branches 641 642 +1
==========================================
+ Hits 2490 2495 +5
- Misses 177 182 +5 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,33 @@ | |||
| import { searchQuery, SearchQuery } from '../src'; | |||
|
|
|||
| const maybe = process.env.CI ? test.skip : test; | |||
There was a problem hiding this comment.
Does this mean we skip these tests on CI? Is that due to the cb server version not supporting FTS?
There was a problem hiding this comment.
Tests were marked to be skipped in the CI due to the data being stored in an FTS index and we don't know the time for they to be ready and return the correct values, so we tried adding some delays but it is uncertain and only worked a few times with 15 sec of delay which is too much delay and even with that fails most the times.
Note: Testing indexed data in a CI can be tricky
There was a problem hiding this comment.
This docs page looks really good 🙂 nice work!
|
This all looks awesome! Just a few small nits, but otherwise looks great! |
The Couchbase server version used in GitHub workflows (main.yml and pull_request.yml) has been updated. The new version 7.1.3 replaces the previous version 7.0.2. This ensures our testing and integration environment uses the latest stable release of Couchbase server.
Added a delay function call in the beforeAll hook in the `fts.spec.ts` file to ensure preconditions are met before test execution. This delay is particularly important in cases where asynchronous setup operations have to be completed before the tests run.
The `maybe` function has been introduced in the `fts.spec.ts` test file to skip tests when in a continuous integration environment. The beforeAll hook using delay has been removed, since test cases are either run or skipped based on the process environment, thereby improving test execution efficiency
gsi-alejandro
force-pushed
the
task/745
branch
from
8a7eb1e
to
fed3e00
Compare
Closes: #745