Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect reference to secure as opposed to useTLS #102

Merged
merged 1 commit into from Nov 17, 2021

Conversation

markspolakovs
Copy link
Contributor

As part of code review for #79, I changed the variable secure to useTLS, but missed some places: this fixes the last remaining one. This wasn't caught because we don't test the form with TLS-enabled clusters - perhaps we should.

As part of code review for #79, I changed the variable `secure` to `useTLS`, but missed some places: this fixes the last remaining one. This wasn't caught because we don't test the form with TLS-enabled clusters - perhaps we should.
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we should test so raise a JIRA for that. Low priority for 0.1 though as we need a lot of other testing too.

@patrick-stephens patrick-stephens added the bug Something isn't working label Nov 17, 2021
@markspolakovs markspolakovs merged commit dec856b into main Nov 17, 2021
@markspolakovs markspolakovs deleted the marks/secure-to-usetls branch November 17, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants