subdoc: push_front/push_back => push_first/push_last

[mnunberg]

The former names C++ functions, and it's not immediately clear what the "front" and "back" actually mean (I'll tell you that these were confusing to me when I was first learning C++).

I believe first/last more intuitively reflects the location of where the items are added to. We can even do 'push_left' and 'push_right'...

[mnunberg]

Upon further consideration, we might use:

• push_at
• push_right
• push_left

[brett19]

I really like push_at, but the push_left and push_right are a bit icky.

[simonbasle]

@brett19 @mnunberg wasn't there a vote for that naming? what was the result? can we commit to anything?

[brett19]

ArrayAppend, ArrayPrepend were the winners, with PushFront, PushBack having similar support but falling in second.

[mnunberg]

So:

array_append
array_prepend
array_insert
array_addunique

Good?

On Mar 15, 2016, at 9:39 AM, Brett Lawson notifications@github.com wrote:

ArrayAppend, ArrayPrepend were the winners, with PushFront, PushBack having similar support but falling in second.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#28 (comment) #28 (comment)

[simonbasle]

Sounds good to me!

[jeffrymorris]

+1