Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Design struct so applications cannot directly construct it #19

Closed
cmbrandenburg opened this issue Jan 4, 2016 · 0 comments
Closed

Change Design struct so applications cannot directly construct it #19

cmbrandenburg opened this issue Jan 4, 2016 · 0 comments
Labels
breaking change
Milestone
v0.5.0

Comments

@cmbrandenburg
Copy link
Member

Add a private field to the Design struct so that applications cannot construct it directly. E.g..,

pub struct Design {
    pub views: ViewFunctionMap,
    _phantom: std::marker::PhantomData<()>,
}

This change, once realized, will allow the Design struct to gain new fields without breaking applications.
@cmbrandenburg cmbrandenburg added this to the v0.5.0 milestone Jan 4, 2016
@cmbrandenburg cmbrandenburg added easy and removed easy labels Jan 4, 2016
@cmbrandenburg cmbrandenburg changed the title Hide fields in Design struct Change Design struct so applications cannot directly construct it Jan 7, 2016
cmbrandenburg added a commit that referenced this issue Jan 8, 2016
@cmbrandenburg
Add deprecation notices for struct construction
f3d155e 
This affects #19, #23, #24, #26, and #27.

Structs whose direct construction has been deprecated:

* `Database`
* `Design`
* `ErrorResponse`
* `ViewResult`
* `ViewRow`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
1 participant
@cmbrandenburg