-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for .buttons class #95
Conversation
Hi @MrCreeper1008 Thanks for the PR. What do you think about changing a little the approach. to use this component like this
wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check this changes? Thanks for the PR btw
@couds I'll combine all the modifications into the next commit. Thanks for the suggestions! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change and will be done!
Excuse the stupid mistake...I forgot to use the renderAs prop... |
Updated original PR description. |
Hi, I'm about to sleep. Could you help me fix it? Thank you :D |
Sure will do |
@couds limiting the |
In storybook I mean |
Thanks for the commit btw |
@couds the |
we can let the storybook as an empty string for the default value but use undefined as a default prop. |
Thanks @couds! |
Doc for
.button
class: https://bulma.io/documentation/elements/button/#list-of-buttons.New component:
<Button.Group />
Props:
New/modified props for
<Button />
:renderAs
now supports<span>
{ isSelected: PropTypes.bool }
Closes issue: #93