Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing rel="noreferrer" #29

Closed
thescientist13 opened this issue Apr 24, 2018 · 1 comment
Closed

implementing rel="noreferrer" #29

thescientist13 opened this issue Apr 24, 2018 · 1 comment

Comments

@thescientist13
Copy link

thescientist13 commented Apr 24, 2018

Hello, I am currently using the latest version of this package available on npm (2.8.1) and am opening this issue per following through on a Lighthouse report I was running against my website, in particular the recommendation that the usage of an anchor tag with the target="_blank" attribute, e.g.

<a href="www.sometime.com" target="_blank">Click me</a>

should also include noopener noreferrer, e.g.

<a href="www.sometime.com" target="_blank" rel="noopener noreferrer">Click me</a>

I see the latest version in GitHub has support for noopener. I would like to make a PR to add noreferrer as well.

From that point, when do you think a new version could be available in GitHub?

Thanks for the great library! ✌️

@thescientist13 thescientist13 changed the title implementing rel="noopener / noreferrer" implementing rel="noreferrer" Apr 24, 2018
@thescientist13
Copy link
Author

thescientist13 commented Apr 24, 2018

oops, nevermind, I see the recommendation is really that only 1 needs to be set (in this case noopener is getting set by this library).

So I guess there isn't anything to do here per se, aside from await a new release of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant