-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cloak #63
Update Cloak #63
Conversation
Do not mergeThis change works in development mode but breaks the build. Because Cloak now has a hard dependency on Underscore, we need to use RequireJS's "map" configuration as we do for the main application build. I'm trying to find a good way to express this without duplication, but it's not as trivial as I would have thought. I'll keep you posted, @mzgoddard . |
Still working on this. In the mean time, I've pinned Cloak to version |
Okay! I've gotten this building correctly. In the process, I've removed another ugly hack (@mzgoddard: |
The latest release of the Cloak library supports AMD, so the AMD "shim configuration" can be removed. Because Cloak now depends on a module with the ID "socket.io-client" and because this path is more accurate than the current alias ("socket.io"), the CEE codebase should be updated to comply.
The latest release of the Cloak library does not suffer from the bug in cleanup logic that prompted this workaround, so it may be safely removed.
Cloak has since been updated to pass connection options through to Socket.io, so the library no longer needs to be monkey-patched in this way.
These dependencies will only be resolved in the context of the running application. Because the application depends on Lodash, external dependencies do not need to be built with an additional copy of that library.
Greg just published Cloak version 0.2.5 for us! I've rebased this onto @stevekinney Would you mind reviewing for me? Since this modifies the build process, you'll also want to test against |
@jugglinmike When I use When I build run it in development, I get the following errors during the build process:
|
@jugglinmike Let me know if you get a chance to poke at this. Maybe it's just my machine, but it would be awesome if someone could confirm that before I merge it. |
@stevekinney Totally! I was out of town last week, but I should have some time to investigate within the next two days. |
You are a gentleman and a scholar. On Mon, Jun 16, 2014 at 10:42 AM, jugglinmike notifications@github.com
|
Hey Steve, I'm unable to reproduce the problems you've described. I've tried to do this in
...the tests passed, the build completed without issue, and I was able to visit Then I thought that maybe a bug is being introduced when my patch is applied to
In this case, I needed to use the I'm a little stumped here. Can you think of anything I'm missing? Maybe we have
...although that seems like a stretch. |
@jugglinmike, Following those steps seems to work. My laptop was a bit behind the times (v0.10.21), I'm not sure if that was the reason, but something in that recipe did the trick. So, I'm going to go ahead and merge it. Now, I just need to have a word with the jerk (me) who left all those linting errors in the money creation chart. 😠 |
The Cloak library has improved since we started working with it! Some of these improvements constitute breaking changes, but in a slight breech of etiquette, they have been published as a "patch" release. This project uses npm's
^
operator for pessimistic dependency resolution, so a breaking change in a patch release blocks other work.Although not technically necessary to move forward, I've took advantage of another improvement and removed that pesky "refresh" logic from the network activities. We all hated that.
@mzgoddard What do you think?