Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate processor from o365beat.yml #7

Closed
wants to merge 1 commit into from
Closed

Remove duplicate processor from o365beat.yml #7

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2019

Removed the duplicate processor statement which prevented the augmentation from working and moved the first processor statement into the processor section.

This meant no processing was taking place except the default add host metadata and cloud metadata.

Removed the duplicate processor statement which prevented the augmentation from working and moved the first processor statement into the processor section.
@ghost ghost changed the title Removed duplicate processor from o365beat.yml Remove duplicate processor from o365beat.yml Nov 7, 2019
@chris-counteractive
Copy link
Collaborator

Thanks for the PR!

This is definitely true: the second processor section "shadows" the first, and has to be removed or merged before use. The problem is, when building the beat the build tools actually create o365beat.yml dynamically by merging _meta/beat.yml with a config file template within the libbeat framework (libbeat/_meta/config.yml.tmpl). It's that .tmpl file that has the extra processor section, and I haven't had time to figure out how to suppress the inclusion of that section. Instead I do what you did in the PR, which is combine them or remove the second processors section altogether.

Unfortunately, if I merge this, it'll be clobbered by the build for the next release and I'll have to re-insert it by hand, which may be the best bet until we sort out a durable fix. Any thoughts on how to suppress the inclusion of the processors section from the libbeat template would be much appreciated! Or, if there's a smarter way to think about the issue, I'm happy to hear that too.

Thanks again for the contribution, I really appreciate the engagement, I'm sure we can sort out a long-term fix for what is definitely a real issue and inconvenience.

@ghost
Copy link
Author

ghost commented Nov 11, 2019

I didn't know about the Libbeat template file. That made me read up a little bit more on making custom beats, and I didn't see how to do that yet.

If I find anything I'll let you know and I completely understand why you shouldn't merge this.

@ghost ghost closed this Nov 11, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant