Make CounterfactulApp methods public (#2517)

* Make CounterfactulApp methods public

* Make other methods public

* [apps] Alon/fix pulic tests (#2584)

* fix: Change function from external to public in NimApp

* chore: Yarn Build everything

* fix: Remove old `expected-build-artifacts`

My build folder had old contracts in it that was causing the `expected-build-artifacts` diff to succeed locally and fail on CI

packages/apps/contracts/HighRollerApp.sol

@@ -49,8 +49,8 @@ contract HighRollerApp is CounterfactualApp {
     bytes32 actionHash;
   }
 
-  function isStateTerminal(bytes calldata encodedState)
-    external
+  function isStateTerminal(bytes memory encodedState)
+    public
     pure
     returns (bool)
   {
@@ -63,10 +63,10 @@ contract HighRollerApp is CounterfactualApp {
 
   // NOTE: Function is being deprecated soon, do not modify!
   function getTurnTaker(
-    bytes calldata encodedState,
-    address[] calldata participants
+    bytes memory encodedState,
+    address[] memory participants
   )
-    external
+    public
     pure
     returns (address)
   {
@@ -75,10 +75,10 @@ contract HighRollerApp is CounterfactualApp {
   }
 
   function applyAction(
-    bytes calldata encodedState,
-    bytes calldata encodedAction
+    bytes memory encodedState,
+    bytes memory encodedAction
   )
-    external
+    public
     pure
     returns (bytes memory)
   {
@@ -147,8 +147,8 @@ contract HighRollerApp is CounterfactualApp {
     return abi.encode(nextState);
   }
 
-  function computeOutcome(bytes calldata encodedState)
-    external
+  function computeOutcome(bytes memory encodedState)
+    public
     pure
     returns (bytes memory)
   {

packages/apps/contracts/NimApp.sol

@@ -23,8 +23,8 @@ contract NimApp is CounterfactualApp {
     uint256[3] pileHeights;
   }
 
-  function isStateTerminal(bytes calldata encodedState)
-    external
+  function isStateTerminal(bytes memory encodedState)
+    public
     pure
     returns (bool)
   {
@@ -34,10 +34,10 @@ contract NimApp is CounterfactualApp {
 
   // NOTE: Function is being deprecated soon, do not modify!
   function getTurnTaker(
-    bytes calldata encodedState,
-    address[] calldata participants
+    bytes memory encodedState,
+    address[] memory participants
   )
-    external
+    public
     pure
     returns (address)
   {
@@ -46,9 +46,9 @@ contract NimApp is CounterfactualApp {
   }
 
   function applyAction(
-    bytes calldata encodedState, bytes calldata encodedAction
+    bytes memory encodedState, bytes memory encodedAction
   )
-    external
+    public
     pure
     returns (bytes memory)
   {
@@ -68,8 +68,8 @@ contract NimApp is CounterfactualApp {
     return abi.encode(ret);
   }
 
-  function computeOutcome(bytes calldata encodedState)
-    external
+  function computeOutcome(bytes memory encodedState)
+    public
     pure
     returns (bytes memory)
   {

packages/apps/contracts/SimpleTransferApp.sol

@@ -18,8 +18,8 @@ contract SimpleTransferApp is CounterfactualApp {
     LibOutcome.CoinTransfer[2] coinTransfers;
   }
 
-  function computeOutcome(bytes calldata encodedState)
-    external
+  function computeOutcome(bytes memory encodedState)
+    public
     pure
     returns (bytes memory)
   {

packages/apps/contracts/SimpleTwoPartySwapApp.sol

@@ -18,8 +18,8 @@ contract SimpleTwoPartySwapApp is CounterfactualApp {
     LibOutcome.CoinTransfer[][] coinTransfers;
   }
 
-  function computeOutcome(bytes calldata encodedState)
-    external
+  function computeOutcome(bytes memory encodedState)
+    public
     pure
     returns (bytes memory)
   {

packages/apps/contracts/TicTacToeApp.sol

@@ -52,8 +52,8 @@ contract TicTacToeApp is CounterfactualApp {
     WinClaim winClaim;
   }
 
-  function isStateTerminal(bytes calldata encodedState)
-    external
+  function isStateTerminal(bytes memory encodedState)
+    public
     pure
     returns (bool)
   {
@@ -63,10 +63,10 @@ contract TicTacToeApp is CounterfactualApp {
 
   // NOTE: Function is being deprecated soon, do not modify!
   function getTurnTaker(
-    bytes calldata encodedState,
-    address[] calldata participants
+    bytes memory encodedState,
+    address[] memory participants
   )
-    external
+    public
     pure
     returns (address)
   {
@@ -75,9 +75,9 @@ contract TicTacToeApp is CounterfactualApp {
   }
 
   function applyAction(
-    bytes calldata encodedState, bytes calldata encodedAction
+    bytes memory encodedState, bytes memory encodedAction
   )
-    external
+    public
     pure
     returns (bytes memory)
   {
@@ -106,8 +106,8 @@ contract TicTacToeApp is CounterfactualApp {
     return abi.encode(postState);
   }
 
-  function computeOutcome(bytes calldata encodedState)
-    external
+  function computeOutcome(bytes memory encodedState)
+    public
     pure
     returns (bytes memory)
   {

packages/apps/contracts/UnidirectionalLinkedTransferApp.sol

@@ -71,19 +71,19 @@ contract UnidirectionalLinkedTransferApp is CounterfactualApp {
     bytes32 preImage;
   }
 
-  function computeOutcome(bytes calldata encodedState)
-    external
+  function computeOutcome(bytes memory encodedState)
+    public
     pure
     returns (bytes memory)
   {
     return abi.encode(abi.decode(encodedState, (AppState)).transfers);
   }
 
   function applyAction(
-    bytes calldata encodedState,
-    bytes calldata encodedAction
+    bytes memory encodedState,
+    bytes memory encodedAction
   )
-    external
+    public
     pure
     returns (bytes memory)
   {
@@ -165,10 +165,10 @@ contract UnidirectionalLinkedTransferApp is CounterfactualApp {
   }
 
   function getTurnTaker(
-    bytes calldata encodedState,
-    address[] calldata participants
+    bytes memory encodedState,
+    address[] memory participants
   )
-    external
+    public
     pure
     returns (address)
   {
@@ -177,8 +177,8 @@ contract UnidirectionalLinkedTransferApp is CounterfactualApp {
     ];
   }
 
-  function isStateTerminal(bytes calldata encodedState)
-    external
+  function isStateTerminal(bytes memory encodedState)
+    public
     pure
     returns (bool)
   {

packages/apps/contracts/UnidirectionalTransferApp.sol

@@ -119,10 +119,10 @@ contract UnidirectionalTransferApp is CounterfactualApp {
   }
 
   function getTurnTaker(
-    bytes calldata encodedState,
-    address[] calldata participants
+    bytes memory encodedState,
+    address[] memory participants
   )
-    external
+    public
     pure
     returns (address)
   {
@@ -131,8 +131,8 @@ contract UnidirectionalTransferApp is CounterfactualApp {
     ];
   }
 
-  function computeOutcome(bytes calldata encodedState)
-    external
+  function computeOutcome(bytes memory encodedState)
+    public
     pure
     returns (
       bytes memory // Encoded version of a LibOutcome.CoinTransfer[2]
@@ -142,10 +142,10 @@ contract UnidirectionalTransferApp is CounterfactualApp {
   }
 
   function applyAction(
-    bytes calldata encodedState,
-    bytes calldata encodedAction
+    bytes memory encodedState,
+    bytes memory encodedAction
   )
-    external
+    public
     pure
     returns (bytes memory)
   {
@@ -210,8 +210,8 @@ contract UnidirectionalTransferApp is CounterfactualApp {
 
   }
 
-  function isStateTerminal(bytes calldata encodedState)
-    external
+  function isStateTerminal(bytes memory encodedState)
+    public
     pure
     returns (bool)
   {