Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

[machine] Deploys for integration tests shouldn't use a hardcoded gas limit #146

Closed
joelalejandro opened this issue Oct 24, 2018 · 2 comments
Labels
📦 Machine code related to packages/machine

Comments

@joelalejandro
Copy link
Contributor

// TODO: Figure out how to not have to put the insanely high gasLimit here
await registry.functions.deploy(initcode, 0, { gasLimit: 6e9 });

@snario
Copy link
Contributor

snario commented Oct 24, 2018

Yeah, generally speaking we shouldn't be arbitrarily setting these value. We should be estimating how much it will cost and appropriately setting the correct amount.

@joelalejandro joelalejandro changed the title [machine] Deploys for integration tests shouldn't use a high gas limit [machine] Deploys for integration tests shouldn't use a hardcoded gas limit Oct 24, 2018
@joelalejandro
Copy link
Contributor Author

Thanks for the input @snario, I've updated the issue title accordingly 👍

@joelalejandro joelalejandro transferred this issue from another repository Oct 31, 2018
@joelalejandro joelalejandro reopened this Oct 31, 2018
@joelalejandro joelalejandro added the 📦 Machine code related to packages/machine label Nov 1, 2018
snario added a commit to pawanjay176/contracts that referenced this issue Nov 6, 2018
* Enforce Airbnb style linting

* Update cache key

* Fix build

* Fix issues noticed in CI

* Fix more issues noticed in CI

* Move 7777777 lookup to runtime

* Remove console.error

* Add --stream to yarn run test

* Consistent linting in iframe wallet too

* Update wallet to reflect new linting

* Fix issues causing errors in iframe-wallet tests.

* Fix linting issue in Joel's PR

* Final lint & build correctness

* Better network context data type handling
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📦 Machine code related to packages/machine
Projects
None yet
Development

No branches or pull requests

2 participants