Freeze Strings #833
Merged
Freeze Strings #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good one 👍, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At work, we've been using this gem at scale (serving ~ 20-100M req/month), and detected this gem to pollute memory by allocating way too many strings.
We've been running this adjustment of freezing multiple strings for six months now without issues (and measurably lower memory footprint).
Sadly, I couldn't find our exact memory profiling results anymore (we did extensive before/after tests using the memory profiler gem and observing memory footprint on the servers).
I remember, that strings for country codes got allocated multiple times before, and only once after freeze strings.
Thank you for maintaining open source :-)