Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion methods for country codes #847

Merged

Conversation

mechnicov
Copy link
Contributor

Useful methods to conversion from alpha-2 to alpha-3 and vice versa

@pmor
Copy link
Member

pmor commented May 17, 2024

Quite useful, thanks for the PR.

Ignore those reek issues, I don't see anything wrong with the naming you picked.

@mechnicov
Copy link
Contributor Author

@pmor
Naming issue is a very delicate matter even for humans. It's too much for machines

@pmor pmor merged commit c1678c8 into countries:master May 18, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants