Merge pull request #5 from achlee/ignore-invalid-paths

Ignore invalid paths

src/Assetic/SourceMapFilter.php

@@ -153,6 +153,7 @@ protected function doFilterDump(CHAssetBag $assetBag, string $tmpOutput, array $
         // the 'sources' property is what dev tools (such as Chrome DevTools) display as the filename for the original source
         // transform tmp file names back to original file name
         $sourceMap['sources'] = array_map(function ($source) use ($tmpInputToAssetMap) {
+
             if (array_key_exists($source, $tmpInputToAssetMap)) {
                 $asset = $tmpInputToAssetMap[$source];
                 if ($asset instanceof HttpAsset) {
@@ -161,13 +162,15 @@ protected function doFilterDump(CHAssetBag $assetBag, string $tmpOutput, array $
 
                 $source = $asset->getSourceRoot() . '/' . $asset->getSourcePath();
             }
-
             // remove the first part of the path - what's left should be relative to the root project directory
             $source = preg_replace("#^{$this->sourceMapSourcePathTrim}#", '', $source);
-
-            $source = Utils\removeRelPathComponents($source);
+
+            try {
+                $source = Utils\removeRelPathComponents($source);
+            } catch (\Exception $e) {
+                // relative paths above the root are ok here
+            }
             $source = ltrim($source, '/');
-
             return $source;
         }, $sourceMap['sources']);
 

tests/SourceMapFilterTest.php

@@ -37,6 +37,7 @@ public function testSourceMapFilterSimple()
         $collection->add($this->makeStringAsset(__DIR__ . '/simple', 'asset1.js'));
         $collection->add($this->makeStringAsset(__DIR__ . '/simple', 'asset2.js'));
         $collection->add($this->makeStringAsset(__DIR__ . '/simple', 'asset3.js'));
+        $collection->add($this->makeStringAsset('/../..', 'climb-above-root.js'));
         $collection = $worker->process($collection, $factory);
 
         $this->assertEquals(file_get_contents('tests/simple/expected.js'), $collection->dump());
@@ -59,7 +60,7 @@ public function testSourceMapFilterComplex()
                 ]]
             ]
         ]);
-        
+
         $factory = $this->createMock(AssetFactory::class);
 
         $collection = new AssetCollection();
@@ -70,7 +71,7 @@ public function testSourceMapFilterComplex()
         $collection = $worker->process($collection, $factory);
 
         $this->assertEquals(file_get_contents('tests/complex/expected.js'), $collection->dump());
-        
+
         $sourceMap = $this->loadSourceMap("$asseticWriteTo/expected.js.map");
         $this->assertEquals($this->loadSourceMap('tests/complex/expected.js.map'), $sourceMap);
     }
@@ -90,7 +91,7 @@ public function testSourceMapFilterComposedSourceMap()
                 ]]
             ]
         ]);
-        
+
         $factory = $this->createMock(AssetFactory::class);
 
         $collection = new AssetCollection();
@@ -100,7 +101,7 @@ public function testSourceMapFilterComposedSourceMap()
         $collection = $worker->process($collection, $factory);
 
         $this->assertEquals(file_get_contents('tests/composed/expected.js'), $collection->dump());
-        
+
         $sourceMap = $this->loadSourceMap("$asseticWriteTo/composed.js.map");
         $this->assertEquals($this->loadSourceMap('tests/composed/expected.js.map'), $sourceMap);
     }